Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Quilt Testing API might have caused longer build times #76

Open
EnnuiL opened this issue Feb 14, 2023 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@EnnuiL
Copy link

EnnuiL commented Feb 14, 2023

I have a suspicion that this commit might have made development more painful by bringing longer build times and such. While I don't have concrete proof, I have tried reverting to QLoom 1.0 with that commit, and OOMs prevented that from working

I suspect that the reason this happens is due to the usage of modTestmodImplementation on QSL's modules and therefore having a need to remap all of them compared to Fabric simply pulling in it's module, which doesn't need remapping;

A solution would be reverting the migration while preventing the module from being published, which could work but wouldn't be ideal since we'll want to use Quilt's solution for game tests of our own;

Something must be investigated that keeps the usage of the Quilt Testing API while not causing the poor build system to suffer

@EnnuiL EnnuiL added bug Something isn't working enhancement New feature or request labels Feb 14, 2023
@EnnuiL
Copy link
Author

EnnuiL commented Jul 31, 2023

Update: I have a plan, I just need time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant