Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsm is no longer supported #6856

Closed
wmertens opened this issue Sep 3, 2024 · 3 comments
Closed

tsm is no longer supported #6856

wmertens opened this issue Sep 3, 2024 · 3 comments
Assignees
@ianlet @JerryWu1234
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request

Comments

@wmertens
Copy link
Member

wmertens commented Sep 3, 2024

Is your feature request related to a problem?

we can't update vfile because tsm doesn't support its import map.

Describe the solution you'd like

We're only using tsm for builds, so we can easily replace it.

Describe alternatives you've considered

use tsnode, or maybe via some small build we don't need anything?

Additional context

No response
@wmertens wmertens added TYPE: enhancement New feature or request COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels Sep 3, 2024
@JerryWu1234
Copy link
Contributor

JerryWu1234 commented Sep 6, 2024 •
edited
Loading

Maybe I can try it.
that files is built by tsnode, because that was built by tsm before. right?

@wmertens
Copy link
Member Author

wmertens commented Sep 6, 2024

@JerryWu1234 yes that would be great, thank you ☺️

@JerryWu1234 JerryWu1234 mentioned this issue Sep 12, 2024
Merged
9 tasks
@shairez shairez assigned shairez and JerryWu1234 and unassigned shairez Sep 24, 2024
@shairez shairez closed this as completed by moving to Done in Qwik Development Nov 4, 2024
@shairez
Copy link
Contributor

shairez commented Nov 4, 2024

fixed by #6877
Thanks @JerryWu1234 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianlet ianlet

@JerryWu1234 JerryWu1234

Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wmertens @shairez @ianlet @JerryWu1234