Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: disabling songs in the database #154

Open
icxes opened this issue Dec 25, 2024 · 1 comment
Open

feature: disabling songs in the database #154

icxes opened this issue Dec 25, 2024 · 1 comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature low-priority issue is not important and likely won't get resolved soon post-1.0 issue won't be resolved until after launch website issue is related to the website and requires backend work

Comments

@icxes
Copy link
Collaborator

icxes commented Dec 25, 2024

There should be a way to make some songs not show up on search/be requestable/be autoplayed while still remaining in the DB. The rationale for this instead of just deleting things is that it

  • would let us disable the stuff that's currently on the DB but probably doesn't belong there little by little while still being able to revert changes if necessary
  • would let some things stay in the DB that are fine when played by DJs, but less so when played by Hanyuu
  • looking at the list of disabled stuff should actually give a pretty good idea of whether something is ok to accept or not when it's not perfectly clear to someone going through pending
@icxes icxes added website issue is related to the website and requires backend work post-1.0 issue won't be resolved until after launch low-priority issue is not important and likely won't get resolved soon labels Dec 25, 2024
@icxes icxes added the feature-request issue is suggesting a new feature or a change to an existing feature label Jan 2, 2025
@Wessie
Copy link
Contributor

Wessie commented Jan 6, 2025

we can probably re-use the usable field in the database, but the current code maps this column to a bool and so can't represent another state. Will keep this as a post-1.0 issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature low-priority issue is not important and likely won't get resolved soon post-1.0 issue won't be resolved until after launch website issue is related to the website and requires backend work
Projects
None yet
Development

No branches or pull requests

2 participants