Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

irc: implement .kill #21

Closed
Wessie opened this issue Jan 22, 2019 · 4 comments
Closed

irc: implement .kill #21

Wessie opened this issue Jan 22, 2019 · 4 comments
Labels
irc issue is related to the irc bot pre-1.0 issue needs to be resolved before launch

Comments

@Wessie
Copy link
Contributor

Wessie commented Jan 22, 2019

a non-access checking version already exists
@Wessie Wessie added pre-1.0 issue needs to be resolved before launch irc issue is related to the irc bot labels Jan 22, 2019
@Wessie
Copy link
Contributor Author

Wessie commented Jan 28, 2019

closed by e4c9594

once HasStreamAccess is implemented this will function as expected

@Wessie Wessie closed this as completed Jan 28, 2019
@Wessie
Copy link
Contributor Author

Wessie commented Feb 3, 2019

reopening because it still doesn't check for access when doing a .kill force

@Wessie Wessie reopened this Feb 3, 2019
@Wessie
Copy link
Contributor Author

Wessie commented Mar 4, 2019

this is now waiting on full implementations of both HasStreamAccess to support non-operator streamers and HasAdminAccess to support .kill force usage

@Wessie
Copy link
Contributor Author

Wessie commented Mar 7, 2019

This will start working completely once #59 and #60 are implemented, until then .kill force will never succeed because of the NotImplemented error returned by those.

@Wessie Wessie closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
irc issue is related to the irc bot pre-1.0 issue needs to be resolved before launch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wessie