Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/admin: add default theme switching in admin panel #71

Closed
excii opened this issue May 30, 2020 · 3 comments
Closed

website/admin: add default theme switching in admin panel #71

excii opened this issue May 30, 2020 · 3 comments
Labels
feature-request issue is suggesting a new feature or a change to an existing feature pre-1.0 issue needs to be resolved before launch website issue is related to the website and requires backend work

Comments

@excii
Copy link

excii commented May 30, 2020

It would be nice to be able to change the default theme from the website for holidays, or for any other reason.

  • Permissions for changing or open to everyone with access?

@Wessie
Copy link
Contributor

Wessie commented May 30, 2020

site-wide default theme should probably just be under admin permissions, djs can only change their own theme

@Wessie Wessie added feature-request issue is suggesting a new feature or a change to an existing feature pre-1.0 issue needs to be resolved before launch website issue is related to the website and requires backend work labels May 30, 2020
@icxes icxes changed the title add default theme switching in admin panel website/admin: add default theme switching in admin panel Feb 19, 2024
@icxes
Copy link
Collaborator

icxes commented Mar 20, 2024

Something to consider is that (iirc) currently we just set every DJ's theme to whatever theme we want to be the "default", which obviously isn't really an option if/when we do DJ themes (it was only fine to do it on current site because we don't have DJ themes). On holidays, holiday themes should still overwrite DJ themes, but probably not user-selected themes, and this should all work without touching the theme_id column in the djs table

So, in other words, there needs to be a way to force some theme "temporarily" without touching the djs table like we are now, and it needs to have priority over whatever the database says that dj's theme should be.

@icxes icxes added post-1.0 issue won't be resolved until after launch and removed pre-1.0 issue needs to be resolved before launch labels Dec 29, 2024
@Wessie Wessie added pre-1.0 issue needs to be resolved before launch and removed post-1.0 issue won't be resolved until after launch labels Jan 3, 2025
@Wessie
Copy link
Contributor

Wessie commented Jan 6, 2025

this is now implemented, currently sits under the admin permission, but should probably get a self-contained permission instead. the holiday theme is adjustable from the admin home page

@Wessie Wessie closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request issue is suggesting a new feature or a change to an existing feature pre-1.0 issue needs to be resolved before launch website issue is related to the website and requires backend work
Projects
None yet
Development

No branches or pull requests

3 participants