Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are failing #3

Open
mr-c opened this issue Oct 30, 2024 · 2 comments
Open

tests are failing #3

mr-c opened this issue Oct 30, 2024 · 2 comments

Comments

@mr-c
Copy link
Contributor

mr-c commented Oct 30, 2024

Thank you for including the tests in html5rdf 1.2.1, however they are failing.

I git bisected it to 7a9f42d

When I run pytest --pdb I see failures like

html5rdf/tests/tokenizer.py:242: in runtest
    assert tokensMatch(expected, received, ignoreErrorOrder, True), errorMsg
E   AssertionError: 
E   
E   Initial state:
E   dataState
E   
E   Input:
E   <!DOCTYPE>
E   
E   Expected:
E   [['DOCTYPE', None, None, None, False]]
E   
E   received:
E   ['ParseError', 'ParseError', ['DOCTYPE', '', None, None, False]]

In addition, another error prevents pytest from showing the errors when not using --pdb, as see in the GitHub Actions runs here:
https://github.com/RDFLib/html5rdf/actions/runs/11587293764/job/32259253810#step:9:604

@ashleysommer
Copy link
Contributor

Yes, I'm aware the tests are failing, I have seen the GitHub actions runs. I haven't had a chance to investigate it yet, other than to confirm the error does not affect the use of this library in the RDFLib project.

@mr-c
Copy link
Contributor Author

mr-c commented Oct 30, 2024

Yes, I'm aware the tests are failing, I have seen the GitHub actions runs. I haven't had a chance to investigate it yet, other than to confirm the error does not affect the use of this library in the RDFLib project.

Got it, thank you. For the Debian package I'll ignore the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants