Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html: use mastodon timeline instead of twitter timeline #121

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Mar 2, 2024

As a piggyback I also removed the twitter link from the community page.

@miri64 miri64 requested review from chrysn and bergzand March 2, 2024 12:22
Copy link

github-actions bot commented Mar 2, 2024

🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-121.surge.sh

@miri64
Copy link
Member Author

miri64 commented Mar 2, 2024

I tweaked the CSS of mastofeed a little bit to fit the theming of our website. The patch for that can be found here: https://github.com/RIOT-OS/mastofeed/tree/riot-theming

Copy link
Member

@chrysn chrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preview on surge.sh allows testing both modes – after accepting cookies, it whows the iframe, without, it shows the fallback.

From looking at the iframe's network activities, we could almost enable it without cookie banner (and without any implications for our ToU) – all it does is loading images from cdn.fosstodon.org (which doesn't even set cookies but we can't guarantee that). There may be easy ways to get rid of these requests or not (removing one more reason why we have a cookie banner in the first place), but for now, this is an improvement.

@miri64 miri64 merged commit 2260d95 into RIOT-OS:master Mar 2, 2024
1 check passed
@miri64 miri64 deleted the twitter/cleanup/rem-twitter-timeline branch March 2, 2024 12:41
@chrysn
Copy link
Member

chrysn commented Mar 2, 2024

Filed fenwick67/mastofeed#65 as a wishlist bug for the next-stage improvements.

@miri64
Copy link
Member Author

miri64 commented Mar 2, 2024

@bergzand also has a PR in the works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants