Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for audio file uploading #137

Open
Tjzabel opened this issue Apr 13, 2019 · 5 comments
Open

Add support for audio file uploading #137

Tjzabel opened this issue Apr 13, 2019 · 5 comments
Labels
help wanted Anyone is welcome to help us with this! needs info Extra attention or information needed new change Adds new capabilities or functionality Telegram Issues relating to Telegram bridge
Milestone

Comments

@Tjzabel
Copy link
Member

Tjzabel commented Apr 13, 2019

Currently, we only support some types of files. If a user wishes to upload an audio file for example, we get [TG Debug] Ignoring non-text message.

We should look into other file types and try to support the uploading of these.

@Tjzabel Tjzabel added help wanted Anyone is welcome to help us with this! good first issue Good for newcomers priority:med new change Adds new capabilities or functionality labels Apr 13, 2019
@Tjzabel Tjzabel self-assigned this May 26, 2019
@nlMeminger nlMeminger self-assigned this May 29, 2019
@nlMeminger
Copy link
Member

I will work on this

@jwflory
Copy link
Member

jwflory commented May 31, 2019

@Tjzabel @nlMeminger I think this needs some planning first. The issue we had previously for the Telegram API is that it exposes the bot API key. So I am guessing we need to use a third-party service to upload audio files like we do with Imgur for images.

Alternatively, we could also build in support for using local file storage for hosting, but that goes beyond the scope of audio files alone since we need to configure a mechanism to store images and also make them available publicly on the Internet.

My preference for this is to either find a third-party service we can use for hosting audio files or close this as a wontfix. Thoughts?

@jwflory jwflory added needs info Extra attention or information needed and removed good first issue Good for newcomers labels May 31, 2019
@nlMeminger
Copy link
Member

My thought was that we would treat audio files like normal documents, and model the audioHandler after the documentHandler. Do you have any thoughts on this approach? I think this would be simpler instead of looking for a third party to host the files like imgur

@jwflory
Copy link
Member

jwflory commented May 31, 2019

I see. I assumed Telegram treated any file other than images as a document. If the TgDocumentHandler does not catch audio files, we can create a new TgAudioHandler class. It comes with the same caveat as documents that if you want to send audio files over the bridge, it will expose the Telegram API token in the IRC channel. But at least this way we can handle audio files so IRC users have context when an audio file is sent.

If we discover a third-party service in the future or some other way to host files, we can always update the class then. 👍

@Tjzabel
Copy link
Member Author

Tjzabel commented May 31, 2019

@jwflory Yep, this issue is covering audio files, and needs a TgAudioHandler to be created in order to handle this.

Documents, in terms of Telegram, only consist of general files. The other file types that are available include are:

  • Audio
  • Animation
  • Game
  • Video
  • Voice

This still brings into question the API key aspect, but we had a question or two about audio files specifically in our Telegram chat, so I figured we may as well include that as another supported file type.

@Tjzabel Tjzabel removed their assignment Sep 15, 2019
@Tjzabel Tjzabel added the Telegram Issues relating to Telegram bridge label Jan 31, 2020
@jwflory jwflory added this to the v2.x.x milestone Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Anyone is welcome to help us with this! needs info Extra attention or information needed new change Adds new capabilities or functionality Telegram Issues relating to Telegram bridge
Projects
None yet
Development

No branches or pull requests

3 participants