Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parallelisation #133

Open
RMeli opened this issue Jun 23, 2024 · 0 comments
Open

Improve parallelisation #133

RMeli opened this issue Jun 23, 2024 · 0 comments

Comments

@RMeli
Copy link
Owner

RMeli commented Jun 23, 2024

PR #113 introduced parallelisation of rmsdwrapper, with the goal of providing a very useful timeout functionality (to avoid hangs in pathological cases where graph isomorphism takes a very long time).

However, the parallelisation over each call is inefficient since the expensive graph isomorphism is computed repeatedly. #113 (comment) describes two potential avenues for more efficient and sensible parallelisation.

Computing the graph isomorphism serially (with timeout) and parallelising over RMSD calculations would also avoid possible clashes with internal parallelisation of the graph isomorphism algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant