Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver verify update: Set verify tolerance based on datatype used in majority of the model #2293

Closed
CharlieL7 opened this issue Oct 5, 2023 · 1 comment
Closed

Driver verify update: Set verify tolerance based on datatype used in majority of the model #2293

CharlieL7 opened this issue Oct 5, 2023 · 1 comment
Assignees
@CharlieL7
Labels
bugfix Fixes a bug found in the code. roadmap Tasks to finish for a release

Comments

@CharlieL7
Copy link
Collaborator

  • This is an issue for fp16 models where most of the calculations are done with fp16 but the final result is converted to fp32
    • The wrong tolerance will be set for for these models leading a to a failure.
  • For the interim, we can supply QA specific tolerances for these models as different driver commands.
@CharlieL7 CharlieL7 added roadmap Tasks to finish for a release bugfix Fixes a bug found in the code. labels Oct 5, 2023
@CharlieL7 CharlieL7 self-assigned this Oct 5, 2023
@CharlieL7 CharlieL7 changed the title Driver verify update: Change tolerance to depend on what datatype is used for the majority of the model rather than the final output type Driver verify update: Set verify tolerance based on datatype used in majority of the model Oct 5, 2023
@CharlieL7
Copy link
Collaborator Author

Handled with checking if fp16 datatype is used anywhere in the model for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CharlieL7 CharlieL7

Labels
bugfix Fixes a bug found in the code. roadmap Tasks to finish for a release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CharlieL7