Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit GPU memory allocation of literals to be a predefined value #3131

Closed
eddieliao opened this issue May 29, 2024 · 2 comments
Closed

Limit GPU memory allocation of literals to be a predefined value #3131

eddieliao opened this issue May 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@eddieliao
Copy link
Contributor

Add either a hard-coded or compile-time argument to set a predefined limit for GPU memory allocation of literals. Proof of concept for eventual weight streaming implementation.

@eddieliao eddieliao added the enhancement New feature or request label May 29, 2024
@eddieliao eddieliao self-assigned this May 29, 2024
@eddieliao
Copy link
Contributor Author

HIP has a env var that can be set called HIP_HIDDEN_FREE_MEM which allows one to hide a certain amount of free memory from hipMemGetInfo(). Would prefer a env var that can just limit max free memory but I guess this works as well?
https://github.com/ROCm/clr/blob/4ec3a977b21da0025609fad0564edaa98436e077/rocclr/utils/flags.hpp#L182-L184

@eddieliao
Copy link
Contributor Author

Created a proof of concept with fixed budget that can be set at compile time. Attached are the outputs of perf runs for no streaming, streaming with unlimited budget, and streaming with fixed budget.
resnet_perf.txt
resnet_perf_streaming_no_budget.txt
resnet_perf_streaming_50000000.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant