Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[impr]: RENAME requirements.txt to rbuild.json #3293

Open
yiakwy-xpu-ml-framework-team opened this issue Jul 22, 2024 · 3 comments
Open

[impr]: RENAME requirements.txt to rbuild.json #3293

yiakwy-xpu-ml-framework-team opened this issue Jul 22, 2024 · 3 comments

Comments

@yiakwy-xpu-ml-framework-team

Problem Description

Description

The name of "requirements.txt" is misleading. It is actually an internal rbuild config file (project name , branch name, commit id).

I requested to change the file name to reflect its nature so that python dependencies and C++ project (or super project) dependencies won't be mixed.

Operating System

Ubunu22.04

CPU

AMD EPYC 9534 64-Core Processor

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

Steps to Reproduce

N/A

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team changed the title [Issue]: RENAME requirements.txt to rbuild.json [impr]: RENAME requirements.txt to rbuild.json Jul 22, 2024
@pfultz2
Copy link
Collaborator

pfultz2 commented Jul 22, 2024

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

@yiakwy-xpu-ml-framework-team
Copy link
Author

yiakwy-xpu-ml-framework-team commented Jul 23, 2024

The requirements.txt is used by cget(which is what rbuild uses) so users can install migraphx with its 3rd-party dependencies automatically.

Thank you for instant response @pfultz2. So could we use a better name to reflect this ?

@pfultz2
Copy link
Collaborator

pfultz2 commented Jul 23, 2024

So could we use a better name to do reflect this ?

We could, but cget would need to be updated to support such a name. There is this issue here to support requirments.cget and also this issue here to support requirements.cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants