-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTest improvements #3140
Comments
Recommend to add to the list of investigation: why skipping a test is taking so long? It does not make sense to spend 3 seconds just to skip a test IMHO
|
@junliume because they initialize the buffers and skip the test. We have A LOT of similar issues. It is already described in https://github.com/ROCm/MIOpen/wiki/GTest-development#early-skip
It happened because initially we've added this evil patter to all GTESTS and even for our "smoke" tests, we initialize ALL the buffers for most of the tests disabled by MIOPEN_TEST_ALL or restricted by the particular data type, because most of the tests check MIOPEN_TEST_ALL and MIOPEN_FLOAT inside the test body right after all the initialization. |
Thank you for the detailed explanation @CAHEK7
Let's discuss further on ways to resolve these issues :) |
It's an umbrella ticket for better tracking of GTest improvement activity ordered by priority.
The tickets under the different checkboxes are independent and can be done in-parallel, while tickets under the same checkbox must be done sequential and in a predefined order.
1) Add custom cmake test wrapper which can get gtest_parallel and run a single-binary test with custom regexp #3132
2) Rename gtests according to the new scheme #3133
3) Remove environment variables from gtest #3134
The text was updated successfully, but these errors were encountered: