[Issue]: "unused" dependencies in requirements.txt

[AngryLoki]

Problem Description

Hi,

At this moment https://github.com/ROCm/hipBLASLt/blob/develop/tensilelite/requirements.txt in tensilelite adds simplejson, ujson and orjson libraries. However in the source code only yaml and msgpack are supported (and this is not the only place, there are other places which support only .yaml or .dat):

hipBLASLt/tensilelite/Tensile/TensileCreateLibrary.py

Lines 715 to 716 in e13e133

	argParser.add_argument("--library-format", dest="LibraryFormat", choices=["yaml", "msgpack"],
	action="store", default="msgpack", help="select which library format to use")

Also packaging seems to be unused (at least directly). Original Tensile library does not use these libraries - https://github.com/ROCm/Tensile/blob/develop/requirements.txt.

These libraries require additional steps to build hipBLASLt in controlled network-isolated environments (see also #1396 (comment)). Could you remove them?

ROCm Version

ROCm 6.3.0

[ppanchad-amd]

Hi @AngryLoki. Internal ticket has been created to fix this issue. Thanks!

[jichangjichang]

json is used for LogicFormat.
https://github.com/ROCm/hipBLASLt/blob/e13e13351a8167fefec51974786f3822a6e38281/tensilelite/Tensile/TensileCreateLibrary.py#L713C1-L714C98

[AngryLoki]

Noted, I missed that part. Could you still select a single json reader? requirements.txt installs all of them, maybe it was performance bottleneck, but anyways only one library is used.

[lucbruni-amd]

Hi @AngryLoki,

These json libraries are indeed used here:

hipBLASLt/tensilelite/Tensile/TensileCreateLibrary.py

Lines 713 to 714 in e13e133

	argParser.add_argument("--logic-format", dest="LogicFormat", choices=["yaml", "json"], \
	action="store", default="yaml", help="select which logic format to use")

As for packaging, I could not build after simply removing it as it is referenced here:

hipBLASLt/tensilelite/Tensile/Parallel.py

Lines 35 to 37 in e13e133

	from packaging.version import Version
	joblibVer = joblib.__version__
	return Version(joblibVer) >= Version("1.4.0")

As for your question above, I was able to build with a single reader, feel free to give this a try as desired for your environment.

Feel free to open another issue if you have further concerns. Thanks!