Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs a license (closed, but spot for legal discussion) #26

Closed
Kekun opened this issue Jan 18, 2021 · 17 comments
Closed

Needs a license (closed, but spot for legal discussion) #26

Kekun opened this issue Jan 18, 2021 · 17 comments
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@Kekun
Copy link
Contributor

Kekun commented Jan 18, 2021

What about GPL? Or MIT maybe?

@Cogboy
Copy link

Cogboy commented Jan 18, 2021

From my understanding this project is a decompiling of a proprietry engine which really means the code here really shouldn't be distributed at all or relicensed.

As much as it is great to have these ports on PC, I would not be surprised if the repos get pulled in the near future.

@sedme0
Copy link
Contributor

sedme0 commented Jan 18, 2021

From my understanding this project is a decompiling of a proprietry engine which really means the code here really shouldn't be distributed at all or relicensed.

As much as it is great to have these ports on PC, I would not be surprised if the repos get pulled in the near future.

I agree on the whole thing where it shouldn't be relicensed, but SEGA usually doesn't interfere much with fan projects. I suppose in this case they might, since it renders their monetization of the Sonic 1 and 2 mobile ports somewhat moot.

@Kekun
Copy link
Contributor Author

Kekun commented Jan 18, 2021

I'll investigate the distributability of such code.

@Cogboy
Copy link

Cogboy commented Jan 18, 2021

From my understanding this project is a decompiling of a proprietry engine which really means the code here really shouldn't be distributed at all or relicensed.
As much as it is great to have these ports on PC, I would not be surprised if the repos get pulled in the near future.

I agree on the whole thing where it shouldn't be relicensed, but SEGA usually doesn't interfere much with fan projects. I suppose in this case they might, since it renders their monetization of the Sonic 1 and 2 mobile ports somewhat moot.

Less SEGA and more Christian Whitehead considering it's his product. I'm not sure his standing on redistributing his game engine code.

I'll investigate the distributability of such code.

Copyright law is pretty clear cut methinks.

@Kekun
Copy link
Contributor Author

Kekun commented Jan 18, 2021

Except this is neither Christian's sources nor the distributed binary, and reverse engineering is allowed to some extent… but I don't know to which extent, and if we crossed the border or not.

@stxticOVFL
Copy link
Collaborator

stxticOVFL commented Jan 18, 2021

Reverse engineering it is not against copyright law. Most of the code here is more-or-less custom, anyway. Infact, we are getting subtle help from the developers from afar. The only way we'd get taken down is if Sonic was directly referenced in any assets. I'm keeping this issue open for more discussion, however, but we are not adding a license.

@stxticOVFL stxticOVFL added invalid This doesn't seem right wontfix This will not be worked on labels Jan 18, 2021
@Cogboy
Copy link

Cogboy commented Jan 18, 2021

Except this is neither Christian's sources nor the distributed binary, and reverse engineering is allowed to some extent… but I don't know to which extent, and if we crossed the border or not.

Reverse engineering it is not against copyright law. Most of the code here is more-or-less custom, anyway. Infact, we are getting subtle help from the developers from afar. The only way we'd get taken down is if Sonic was directly referenced in any assets. I'm keeping this issue open for more discussion, however, but we are not adding a license.

Fair dos. In my eyes though a decompliation implies that compiled binary code has be decompiled into readable source code rather than reverse-engineering. Might be worth clarifying that somewhere so that muppets like me don't misinterpreate the project.

@Clownacy
Copy link

If reverse-engineering is so exempt from copyright law then why the hell did my decompilation get DMCA'd?

@Rubberduckycooly
Copy link
Collaborator

If reverse-engineering is so exempt from copyright law then why the hell did my decompilation get DMCA'd?

While reverse-engineering is pretty fair game since its not direct piracy, different companies handle this kinda stuff differently. We're greatful Sega doesn't take this down themselves, because should they want to they'd probably have every right to do so (and there wouldn't be much we could do)

@stxticOVFL
Copy link
Collaborator

stxticOVFL commented Jan 19, 2021

To add to this, this decomp is similar enough like the SM64 decomp, which is handwritten decompiled code with assets needed to run, of which Nintendo, the more typical trigger-happy company, can't take down. (For reference, many areas of this decomp used IDA, while a lot of areas of the SM64 decomp used a similar, more custom tool.)

@stxticOVFL stxticOVFL changed the title Needs a license Needs a license (kept open as a spot for legal discussion) Jan 19, 2021
@stxticOVFL stxticOVFL pinned this issue Jan 20, 2021
@stxticOVFL
Copy link
Collaborator

just realized i could just close and pin LOL

@stxticOVFL stxticOVFL changed the title Needs a license (kept open as a spot for legal discussion) Needs a license (closed, but spot for legal discussion) Jan 20, 2021
@Rings4
Copy link

Rings4 commented Jan 20, 2021

From my understanding this project is a decompiling of a proprietry engine which really means the code here really shouldn't be distributed at all or relicensed.
As much as it is great to have these ports on PC, I would not be surprised if the repos get pulled in the near future.

I agree on the whole thing where it shouldn't be relicensed, but SEGA usually doesn't interfere much with fan projects. I suppose in this case they might, since it renders their monetization of the Sonic 1 and 2 mobile ports somewhat moot.

I'd argue that it may boost sales for the mobile ports of the games, since those are required for this decompilation to work in the first place.

@stxticOVFL
Copy link
Collaborator

We are encouraging to download the mobile ports as much as we can, yes. We've had to tell people why they shouldn't just download from an APK site quite often in various Discords cause of it.

@Rings4
Copy link

Rings4 commented Jan 20, 2021

We are encouraging to download the mobile ports as much as we can, yes. We've had to tell people why they shouldn't just download from an APK site quite often in various Discords cause of it.

Yeah, I know a few people who bought S3&K on Steam solely because of Sonic 3 AIR. I'm sure the same can apply here, even moreso since this decompilation can apparently be made to run on multiple platforms and systems.

@Clownacy
Copy link

Update: 531e3b9 added The Unlicence.

@Clownacy
Copy link

Clownacy commented Apr 1, 2021

The license has now been changed to a custom non-commercial one in 2ba9236.

@asm95
Copy link

asm95 commented May 10, 2021

As @Rubberduckycooly said, every project will depend on how the original developers treat their product. In some cases, they won't tolerate this kind of derived work and it's all up to the reversing team to decide whether is worth to waste their time/money in legal battles. Most of them won't and simply will shutdown the project.

We have luck that SEGA have a good relationship with the modding community as it doesn't see them as threat to their business (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

8 participants