Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle catalogs that do not have unique source names #158

Open
bhazelton opened this issue Sep 27, 2021 · 1 comment
Open

Comments

@bhazelton
Copy link
Member

This came up with both LoBES and GLEAM, which use RA & Dec to some precision to make the names (standard in astronomy). However, nearby distinct sources can end up with the same name and we need a way to distinguish them. But I don't really like changing (or not preserving in some way) the original names in the catalog. Maybe we need a new attribute?

@bhazelton
Copy link
Member Author

One option is to have an optional attribute called "original_name" that gets filled if there are non-unique names and we modify the names to make them unique (with a warning). Then on write there could be an option to write out with the original names rather than our assigned ones.

Another option is to have an integer attribute which is only non-zero if there are any non-unique names and then it increases from zero for each new instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant