Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor equality testing in uvbase and parameter to allow diff printing and move printing in __eq__ calls to logging #1265

Open
bhazelton opened this issue Feb 23, 2023 · 0 comments

Comments

@bhazelton
Copy link
Member

It would be useful to be able to print the differences between objects without calling __eq__ and we probably do not want __eq__ to print out things by default (it's super useful in test debugging but probably not very useful for users).

Proposal is to move all the code to a helper function that returns a message containing information about the differences.

Then add a method to just print that info, and update the __eq__ function to call it without the printing but add it to logging with a level of "info".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant