Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color based metal tank keys #346

Open
liach opened this issue Jan 31, 2019 · 3 comments
Open

Color based metal tank keys #346

liach opened this issue Jan 31, 2019 · 3 comments
Labels
bug good first issue high priority

Comments

@liach
Copy link
Contributor

liach commented Jan 31, 2019

They are missing localization even in en_us now. Need to fix this at some point, preferably before release.
@CovertJaguar
Copy link
Member

Do we remove the color labels entirely?

@liach
Copy link
Contributor Author

liach commented Jan 31, 2019

we did not have color in the localization tags for metal tanks before.

@CovertJaguar
Copy link
Member

Indeed. And I'm fine with it staying that way. Which means the Item class probably needs adjusting.

@liach liach mentioned this issue Feb 15, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CovertJaguar @liach