-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Fix the zero calculation in Pythagorean Theorem Calculator #1811
Comments
Hey @srilekha279, Welcome to the project CalcDiverse! 🎊 |
Go ahead @srilekha279 |
Should I fix the bug first and then raise a separate issue for the enhancement? |
What kind of enhancement @srilekha279 |
Instead of taking two sides as input, I want to take 3 sides as input and calculate the missing side if the hypotenuse and one side are given, calculate the hypotenuse if 2 other sides are given and |
You just fix the bug in this issue by creating a PR, we already have Pythagorean Triples Calculator @srilekha279 |
I understand that the current Pythagorean Triples Calculator validates triplets, but I believe adding the following feature will significantly enhance its functionality Calculate Missing Side: If the hypotenuse and one side are given. The current Pythagorean Triplet Calculator only checks whether a triplet is valid. I propose to calculate any side of a right triangle, not just the hypotenuse. |
@Rakesh9100 |
Hello @srilekha279! Your issue #1811 has been closed. Thank you for your contribution!! 🙌 |
Description
The current implementation of the hypotenuse calculator has a bug where it incorrectly calculates the hypotenuse when one of the sides is entered as zero.
Steps to Reproduce:
What I want to improve
Input Handling:
Allow users to input values into three fields: side a, side b, and hypotenuse.
Calculations: Implement logic to:
Screenshots
Checklist
Code of Conduct
The text was updated successfully, but these errors were encountered: