Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix negative inputs in Logarithm Calculator #630

Closed
4 of 7 tasks
Aarzookhunger opened this issue May 9, 2024 · 5 comments · Fixed by #774
Closed
4 of 7 tasks

[Bug] Fix negative inputs in Logarithm Calculator #630

Aarzookhunger opened this issue May 9, 2024 · 5 comments · Fixed by #774
Assignees
Labels
bug 🐞 Something isn't working enhancement ✨ New feature or request gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points

Comments

@Aarzookhunger
Copy link
Contributor

Aarzookhunger commented May 9, 2024

Description

In the logarithm calculator input section, the inputs are being taken through numeric sliders.
Now since we know that logarithm of negative numbers can't be calculated nor the base could be negative or one so rather than generating alert after we press Calculate Log option, how about we restrict the sliders to go beyond.
Also we can apply a simultaneous check which won't let us enter non-positive numbers through keyboard input as well.
[https://calcdiverse.netlify.app/calculators/logarithm-calculator/]

Screenshots

No response

Checklist

  • I have checked the existing issues.
  • I follow Contributing Guidelines of this project.
  • I am a GSSOC'24 contributor.
  • I am a IWOC'24 contributor.
  • I am a JWOC'24 contributor.
  • I am a SWOC'24 contributor.

Code of Conduct

Copy link

github-actions bot commented May 9, 2024

Hey @Aarzookhunger, Welcome to the project CalcDiverse! 🎊
Thanks for opening an issue! 🙌 Please wait for the issue to be assigned. Happy Coding!! ✨

@IP80808080
Copy link

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Additionally, could you please label it for the appropriate level? Thank you! 🚀

@Aarzookhunger
Copy link
Contributor Author

Aarzookhunger commented May 11, 2024

@Rakesh9100
Kindlly label the issue under GSSoC and assign level to it.
Also assign this issue to me for GSSoC'24 contribution.
I'll be glad to resolve this issue and make my contribution to open-source community.

Thanks!

@Rakesh9100
Copy link
Owner

Go ahead @Aarzookhunger

@Rakesh9100 Rakesh9100 added the gssoc GSSoC 2k24 Open Source Program label May 19, 2024
@Rakesh9100 Rakesh9100 changed the title Logarithmic Calculator input issue. [Bug] Fix negative input in Logarithm Calculator May 19, 2024
@Aarzookhunger
Copy link
Contributor Author

@Rakesh9100
Kindly add label regarding the level as well.

Thankyou!

@Rakesh9100 Rakesh9100 added bug 🐞 Something isn't working enhancement ✨ New feature or request level2 GSSoC2k24 Level-2 Task -- 25 Points labels May 24, 2024
@Rakesh9100 Rakesh9100 changed the title [Bug] Fix negative input in Logarithm Calculator [Bug] Fix negative inputs in Logarithm Calculator May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working enhancement ✨ New feature or request gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points
Projects
None yet
3 participants