Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last line character cut off using netcat - is this some \n vs \r\n issue? #395

Open
ghost opened this issue Apr 3, 2020 · 1 comment
Open

Comments

@ghost
Copy link

ghost commented Apr 3, 2020

Describe the bug
When connecting via netcat, the last input character is cut off. With telnet it works. Do you hardcode-assume \r\n and cut off a character when a line just terminates in \n? I get that this is what most telnet clients would send, but IMHO you should still be flexible with this on the input side even when strict with it on the output side.

To Reproduce
Connect via netcat, enter account name -> suggested name has last character cut off

Expected behavior
All types of line breaks are processed correctly. You may also want to treat single \r as a correct line break for robustness (even if it's not followed by \n).

Error logs
No idea, don't have server access to this instance

Environment (please complete the following information):
Again no idea

Additional context
Add any other context about the problem here.

@Akeri
Copy link

Akeri commented May 18, 2020

Same issue here.
However using telnet is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants