Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http.delete fails is body / json parameter is not passed #18

Open
iddogino opened this issue Jun 8, 2018 · 2 comments
Open

Http.delete fails is body / json parameter is not passed #18

iddogino opened this issue Jun 8, 2018 · 2 comments

Comments

@iddogino
Copy link
Contributor

iddogino commented Jun 8, 2018

No description provided.

@alexwalling
Copy link
Member

I was looking into solving this issue and believe I've come up with a solution, but while trying to fix/test it I also noticed that the Http tests aren't being run.

@iddogino
Copy link
Contributor Author

Hey Alex,

Look at test/driverTests.js:19. That section is commented out, as those tests are commented out. If you un-comment that section, the http tests will run.

The reason for that is that they are too slow on the ci/cd machine. The solution would be to eventually switch to the jest test runner, and stub the http requests, but for now you can just uncomment it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants