Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 3 - Ch 12.3: Position to measure theta_max #1624

Open
cmookj opened this issue Aug 27, 2024 · 0 comments
Open

Book 3 - Ch 12.3: Position to measure theta_max #1624

cmookj opened this issue Aug 27, 2024 · 0 comments
Milestone

Comments

@cmookj
Copy link

cmookj commented Aug 27, 2024

Following all the contents up to Ch. 12.3, I think the angular measurement of theta should be at the center of the sphere, C, not at p. Hence, cos(theta_max) = R / || c - p ||.

I think the verification using the extreme cases also needs update accordingly.

The solid angle is
2 pi (1 - cos(theta_max))
and when R is extremely small, theta_max is nearly pi/2 and the solid angle approaches to 2 pi. This case is similar to the Sun lighting the half of the Earth from far, far away. If the sphere is tangent to p, theta_max approaches to 0, and cos(theta_max) goes to 1. The solid angle becomes 0. This makes sense because if we assume the Sun to be a point, and when it is right on the surface of the Earth, only a single point, where the Sun is, is illuminated.

@hollasch hollasch added this to the Backlog milestone Aug 27, 2024
@github-staff github-staff deleted a comment from mayank785 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@hollasch @cmookj and others