From e61f35457f6fdd352f6241f0c5fef86cdee4baa0 Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 3 Aug 2023 10:17:28 -0700 Subject: [PATCH 1/4] Add missing includes --- src/attributes.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/attributes.cpp b/src/attributes.cpp index 4364db4c2..178206205 100644 --- a/src/attributes.cpp +++ b/src/attributes.cpp @@ -31,6 +31,7 @@ #include #include #include +#include // for std::endl #include #include From 5d30741c982b17d8cde657703f6619e14f5e47b5 Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 3 Aug 2023 10:19:58 -0700 Subject: [PATCH 2/4] Update date.cpp --- src/date.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/date.cpp b/src/date.cpp index 1c66c934d..ae6f30fe6 100644 --- a/src/date.cpp +++ b/src/date.cpp @@ -25,6 +25,7 @@ #define COMPILING_RCPP +#include // for TRUE,FALSE #include #include // for gmtime #include From 2236c5c928679eed5f4997f5fa9d16ba5c32a8ef Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 3 Aug 2023 10:31:07 -0700 Subject: [PATCH 3/4] Update ChangeLog --- ChangeLog | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index c7d858a35..9507c8a6c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2023-08-03 Michael Chirico + + * src/attributes.cpp: Directly `#include ` for `std::endl` + * src/date.cpp: Directly `#include ` for `TRUE` and `FALSE` + 2023-07-03 Dirk Eddelbuettel * DESCRIPTION (Date, Version): Release 1.0.11 From 7b0ec9c69ce6dcd89e7057cfbb8e173fa106bbcd Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 3 Aug 2023 10:32:05 -0700 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4341d6b92..34891f791 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,5 +7,5 @@ Please explain the changes you want to apply to Rcpp, preferably in an issue tic - [ ] Code compiles correctly - [ ] `R CMD check` still passes all tests -- [ ] Prefereably, new tests were added which fail without the change +- [ ] Preferably, new tests were added which fail without the change - [ ] Document the changes by file in [ChangeLog](https://github.com/RcppCore/Rcpp/blob/master/ChangeLog)