Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revdep dbi.table broken by with=FALSE #6671

Open
tdhock opened this issue Dec 19, 2024 · 0 comments
Open

revdep dbi.table broken by with=FALSE #6671

tdhock opened this issue Dec 19, 2024 · 0 comments
Labels
revdep Reverse dependencies
Milestone

Comments

@tdhock
Copy link
Member

tdhock commented Dec 19, 2024

revdep check machine
says #6487 broke dbi.table tests:

* checking tests ...
  Running 'testthat.R'
 ERROR
Running the tests in 'tests/testthat.R' failed.
Complete output:
  > # This file is part of the standard setup for testthat.
  > # It is recommended that you do not modify it.
  > #
  > # Where should you do additional test configuration?
  > # Learn more about the roles of various files in:
  > # * https://r-pkgs.org/testing-design.html#sec-tests-files-overview
  > # * https://testthat.r-lib.org/articles/special-files.html
  > 
  > library(testthat)
  > library(dbi.table)
  Loading required package: data.table
  > 
  > test_check("dbi.table")
  [ FAIL 2 | WARN 332 | SKIP 0 | PASS 264 ]
  
  == Failed tests ================================================================
  -- Failure ('test-dbi.table.R:77:5'): j syntax consistent with data.table ------
  reference.test(Track[, 1:MediaTypeId], verbose = FALSE) is not TRUE
  
  `actual`:   FALSE
  `expected`: TRUE 
  -- Failure ('test-dbi.table.R:77:5'): j syntax consistent with data.table ------
  reference.test(Track[, 1:MediaTypeId], verbose = FALSE) is not TRUE
  
  `actual`:   FALSE
  `expected`: TRUE 
  
  [ FAIL 2 | WARN 332 | SKIP 0 | PASS 264 ]
  Error: Test failures
  Execution halted
* checking for unstated dependencies in vignettes ... OK

@MichaelChirico @jangorecki you commented on that PR so can you please investigate?

@tdhock tdhock changed the title revdep revdep dbi.table broken by with=FALSE Dec 19, 2024
@tdhock tdhock added the revdep Reverse dependencies label Dec 19, 2024
@tdhock tdhock added this to the 1.17.0 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revdep Reverse dependencies
Projects
None yet
Development

No branches or pull requests

1 participant