Fix/goals margin #138
Closed
Fix/goals margin #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| @@ -37,7 +37,7 @@ const Card = ({ item, posStyle, changecard, removeCard }: props) => { | |||
| useEffect(() => { | |||
| // Clear the interval when the component unmounts | |||
| return () => clearTimeout(timerRef); | |||
| }, []); | |||
| }); | |||
There was a problem hiding this comment.
why did we remove the empty brackets?
if we put an empty [], code inside useEffect it runs only once. Without empty [], the code inside the useEffect runs on every render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #136
Fixed multiple issues
Files that I changed manually:
package-lock.json(did this after talking to Vinayak and Priyansh on app call)src/components/CreateGoalForm/DatePicker.tsx(to fix pre commit error)src/components/ProgressBar/index.tsx(to fix pre commit error)src/components/ShortGoalsComponent/ShortGoalsComponent.tsx(to fix this issue)All tests for the build have been successful