remove all dev=true feature flag from the main branch that are on prod for more than 14 days

[yesyash]

Issue Description

• we have a lot of features under the feature flag that have been live on prod for a long time but not removed from the feature flag, making it hard to develop new features / fix existing bugs as there are a lot of flows that need to be considered before making a change.
• we need to remove all feature flags that have been live on prod for more than 14 days.
• we also need to remove the feature flags from other repos where they are being used

[iamitprakash]

if needed more info on this please get in touch with @prakashchoudhary07 @iamitprakash @yesyash

[samarpan1738]

Doubts

1. How to identify that a feature flag has been live on prod for more than 14 days? (My guess is by checking when the PR was merged on the prod branch)
2. Do we need to keep only the dev == true flows?

@prakashchoudhary07 @iamitprakash @yesyash

[samarpan1738]

APIs with feature flag

1. POST /discord-actions/nicknames/sync
2. GET /logs
3. POST /extension-requests
4. GET /extension-requests/self
5. GET /requests
6. POST /requests
7. PUT /requests/:id
8. GET /users
9. GET /users/username
10. GET /users/search
11. GET /tasks
12. GET /github/callback

@iamitprakash

[samarpan1738]

Usages of APIs with feature flag in other repositories

Note: Checked means FF is being used and unchecked means FF is not being used

1. POST /discord-actions/nicknames/sync
   1. website-dashboard ✅
   2. cron-jobs ✅
2. GET /logs
   1. website-dashboard ✅
   2. website-api-contracts ✅
3. POST /extension-requests
   1. Reasons for adding dev FF
      1. Create multiple extension requests - PR link
   2. Usages
      1. mobile-app 🟥
      2. website-my - ✅
      3. website-api-contracts ✅
4. GET /extension-requests/self
   1. website-my ✅
   2. website-api-contracts ✅
5. GET /requests
   1. website-api-contracts ✅
   2. website-my ✅
   3. website-dashboard ✅
6. POST /requests
   1. website-my ✅
   2. website-api-contracts ✅
7. PUT /requests/:id
   1. website-dashboard ✅
8. GET /users - Discussed with Prakash. Skipping this for now since it's not being used in majority of the places
   1. Reason for adding dev FF
      1. To get user by discord id through a query param for /user discord command
      2. Change query param with name query to q
   2. Usages
      1. discord-slash-commands - Partial use 🟨
      2. members-site 🟥
      3. mobile-app 🟥
      4. website-dashboard 🟥
      5. website-status 🟥
9. GET /users/username - dev FF is still being used here. Skip this
   1. website-my ✅
10. GET /users/search Discussed with Prakash. Skipping this for now since it's not being used in majority of the places
    1. Reason for adding dev FF
       1. Add pagination when multiple filter is applied and user count greater than 100 - PR link
    2. Usages
       1. website-dashboard - Partial use 🟨
       2. discord-slash-commands 🟥
11. GET /tasks
    1. discord-slash-commands ✅
    2. mobile-app ✅
    3. website-dashboard ✅
    4. website-status ✅
12. GET /github/callback - Discussed with Prakash. Skipping this since he doesn't remember why this was added
    1. Reason for adding dev FF
       1. dev FF is being checked in the redirect url
       2. If dev=true , do not redirect . PR link

[samarpan1738]

Subtasks

1. Remove dev feature flag from POST /discord-actions/nicknames/sync API #2128
2. Remove dev feature flag from GET /logs API #2136
3. Remove dev feature flag from POST /extension-requests API #2137
4. Remove dev feature flag from GET /extension-requests/self API #2138
5. Remove dev feature flag from GET /requests API #2139
6. Remove dev feature flag from POST /requests API #2140
7. Remove dev feature flag from PUT /requests/:id API #2141
8. Remove dev feature flag from GET /users API #2142
9. Remove dev feature flag from GET /users/username API #2143
10. Remove dev feature flag from GET /users/search API #2144
11. Remove dev feature flag from GET /tasks API #2145
12. Remove dev feature flag from GET /github/callback API #2146

[samarpan1738]

Picking the following APIs in the scope of this task

1. POST /extension-requests
2. POST /discord-actions/nicknames/sync
3. GET /logs
4. GET /requests
5. GET /extension-requests/self
6. POST /requests
7. PUT /requests/:id

Note

Other APIs have breaking changes in the places they are being used. So skipping them in this task.
Created a todo issue to manage these APIs

Pull requests

1. Remove dev feature flag for POST /extension-requests API #2150
2. Remove dev feature flag for POST /discord-actions/nicknames/sync API #2148
3. Remove dev feature flag for GET /logs API #2149
4. Remove dev feature flag for GET /requests API #2151
5. Remove dev feature flag for GET /extension-requests/self API #2152
6. Remove dev feature flag for POST /requests and PUT /requests/:id APIs #2153

[samarpan1738]

Created a todo ticket to maintain this pending parts of this task

Real-Dev-Squad/todo-action-items#248

@prakashchoudhary07 @iamitprakash