From dff5a4f802aaacf907dd5868bdaa624d1c36ae60 Mon Sep 17 00:00:00 2001
From: Anmol Chandel <anmolchandel05@gmail.com>
Date: Wed, 7 Aug 2024 22:25:02 +0530
Subject: [PATCH] improved logic to check if a number is perfect

---
 Perfect Numbers/Check Perfect.c     | 16 ++++++++--------
 Perfect Numbers/Perfect Numbers.c   | 19 ++++++++++---------
 Perfect Numbers/Perfect Numbers.cpp | 20 +++++++++++---------
 3 files changed, 29 insertions(+), 26 deletions(-)

diff --git a/Perfect Numbers/Check Perfect.c b/Perfect Numbers/Check Perfect.c
index f5e24d54..0b895d93 100644
--- a/Perfect Numbers/Check Perfect.c	
+++ b/Perfect Numbers/Check Perfect.c	
@@ -2,15 +2,15 @@
 #include <stdio.h>
 
 int isPerfect(int num){
-  int count=0;
-  for(int i=1;i<num;i++){
-    if(num%i==0){
-      count+=i;
+  if(num==1)return 0;
+    int sum=1;
+    int lim=sqrt(num);
+    
+    for(int n=2;n<=lim;n++){
+        if(num%n==0){sum+=n+(num/n);}
     }
-  }
-  if(num==count)
-    return 1;
-  else
+    
+    if(sum==num)return 1;
     return 0;
 }
 
diff --git a/Perfect Numbers/Perfect Numbers.c b/Perfect Numbers/Perfect Numbers.c
index ddc3aad6..b9782a22 100644
--- a/Perfect Numbers/Perfect Numbers.c	
+++ b/Perfect Numbers/Perfect Numbers.c	
@@ -1,16 +1,17 @@
 //Printing n Perfect Numbers
 #include <stdio.h>
+#include <math.h>
 
 int isPerfect(int num){
-  int count=0;
-  for(int i=1;i<num;i++){
-    if(num%i==0){
-      count+=i;
+  if(num==1)return 0;
+    int sum=1;
+    int lim=sqrt(num);
+    
+    for(int n=2;n<=lim;n++){
+        if(num%n==0){sum+=n+(num/n);}
     }
-  }
-  if(num==count)
-    return 1;
-  else
+    
+    if(sum==num)return 1;
     return 0;
 }
 
@@ -20,7 +21,7 @@ int main(){
   scanf("%d",&num);
   for(int i=0;i<num;){
     if(isPerfect(temp)==1){
-      printf("%d",temp);
+      printf("%d\n",temp);
       i++;
       temp++;
     }
diff --git a/Perfect Numbers/Perfect Numbers.cpp b/Perfect Numbers/Perfect Numbers.cpp
index f63cbbc7..ae37d5c2 100644
--- a/Perfect Numbers/Perfect Numbers.cpp	
+++ b/Perfect Numbers/Perfect Numbers.cpp	
@@ -1,17 +1,19 @@
 #include <iostream>
+#include <cmath>
 
 using namespace std;
 
 int isPerfect(int num){
-  int count=0;
-  for(int i=1;i<num;i++){
-    if(num%i==0){
-      count+=i;
+    
+    if(num==1)return 0;
+    int sum=1;
+    int lim=sqrt(num);
+    
+    for(int n=2;n<=lim;n++){
+        if(num%n==0){sum+=n+(num/n);}
     }
-  }
-  if(num==count)
-    return 1;
-  else
+    
+    if(sum==num)return 1;
     return 0;
 }
 
@@ -29,4 +31,4 @@ int main(){
       temp++;
   }
   return 0;
-}
\ No newline at end of file
+}