Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor visual issue on image detail -> actions after PF5 migration #824

Open
ezr-ondrej opened this issue Aug 15, 2024 · 6 comments
Open

Comments

@ezr-ondrej
Copy link
Member

image

@amirfefer
Copy link
Member

amirfefer commented Aug 15, 2024

I can't reproduce, it seems OK
Screenshot 2024-08-15 at 19 23 42

@ezr-ondrej
Copy link
Member Author

Did you try on stage? maybe there is some battling css styling on stage given there is both PF4 and PF5 css enabled? 🤔
FTR I still see it on stage.

@amirfefer
Copy link
Member

stage:

Screenshot 2024-08-26 at 14 18 39

Also #827 looks fine

@ezr-ondrej
Copy link
Member Author

This one is broken in both FF and chrome.

@ezr-ondrej
Copy link
Member Author

Tho, it's all coming from pf4-v5 style guide, that's enforcing this:

.pf-v5-c-content ul {
  /*! padding-inline-start:var(--pf-v5-c-content--ul--PaddingLeft); *//*! margin-inline-start:var(--pf-v5-c-content--ul--MarginLeft); *//*! list-style:var(--pf-v5-c-content--ul--ListStyle); */
}

That tells me it'll be fixed once platform gets rid of the pf4 :)

@ezr-ondrej
Copy link
Member Author

Oh!! ❗
I've found out, that if you go to edge images, it's ok, if you go to IB -> Immutable -> image, it's broken 😮‍💨 xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants