key.delete always returns okay - whether or not the key exists

[chayim]

In redis, when deleting a key that exists, a 1 is always returned.

127.0.0.1:6379> set foo bar
OK
127.0.0.1:6379> del foo
(integer) 1
127.0.0.1:6379> 

When delete a key that does not exist, a 0 is always returned.

127.0.0.1:6379> keys *
(empty array)
127.0.0.1:6379> del foo
(integer) 0
127.0.0.1:6379> 

Due to this line redismodule-rs always returns okay, on the delete of a key.

This also appears true for unlink unlink.

We should probably return either an OK/Error combination, or ints like Redis, but not always OK.

[oshadmi]

It seems a "breaking" change (not backward compatible)
(there's no such label yet)

[chayim]

Any preference on which? As a reference, redis-py and jedis copy the behaviour of the redis-cli and returns an int - so I'd vote for an int here.

[oshadmi]

@chayim I suggest returning Status (for example, see hash_del)
(actually returningREDISMODULE_OK for int 0 and REDISMODULE_ERR for int 1)