Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and implement proper Redis module API validation #295

Open
MeirShpilraien opened this issue Mar 20, 2023 · 3 comments
Open

Design and implement proper Redis module API validation #295

MeirShpilraien opened this issue Mar 20, 2023 · 3 comments

Comments

@MeirShpilraien
Copy link
Collaborator

MeirShpilraien commented Mar 20, 2023

Different Redis version expose new API that is not presented on old versions.
We should define a solution that will allow the user understand which API he can and can not use and avoid mistakes either on compile time or on runtime.

@oshadmi
Copy link
Contributor

oshadmi commented Mar 22, 2023

For compile time would require to define a min redis version?

@iddm
Copy link
Collaborator

iddm commented Mar 22, 2023

We can use features to specify the Redis version, and in the code use cfg_if! and #[cfg] to enable/disable the code paths relevant.

@MeirShpilraien
Copy link
Collaborator Author

Draft proposal: #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants