Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use marshal for commands #134

Open
Matthias1590 opened this issue Mar 14, 2023 · 6 comments
Open

Use marshal for commands #134

Matthias1590 opened this issue Mar 14, 2023 · 6 comments
Labels
enhancement/refactor Something should be rewritten general/high-priority This has high priority

Comments

@Matthias1590
Copy link
Member

This wrapper would manage optional arguments and integrate the feedback system. Would be a lot cleaner than the mess we have now
@Matthias1590 Matthias1590 added the enhancement/refactor Something should be rewritten label Mar 14, 2023
@Matthias1590
Copy link
Member Author

Not assigning people to this yet, don't want to spend time on this before v1 is released

@orbyfied
Copy link
Contributor

orbyfied commented Mar 14, 2023 •
edited
Loading

I also think we should move the TypeSerializers into com.domain.redstonetools.serializers and develop the command system under com.domain.redstonetools.commands, as they are not features, so I don't think they should be under the features package.

@RUGMJ
Copy link
Member

RUGMJ commented Jun 3, 2023

shouldn't this be closed now because of the marshal repo?

@Matthias1590
Copy link
Member Author

shouldn't this be closed now because of the marshal repo?

I'll rename it

@Matthias1590 Matthias1590 changed the title Create a brigadier wrapper Use marshal for commands Jun 3, 2023
@Matthias1590 Matthias1590 added the general/high-priority This has high priority label Jun 3, 2023
@Matthias1590
Copy link
Member Author

Added the high priority label since the later we refactor to use marshal the more we'd have to change

@Starmania
Copy link

Updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement/refactor Something should be rewritten general/high-priority This has high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Matthias1590 @RUGMJ @Starmania @orbyfied