Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening modeless (= non modal) dialogs/windows #18

Open
giuliohome opened this issue Sep 9, 2018 · 2 comments
Open

Opening modeless (= non modal) dialogs/windows #18

giuliohome opened this issue Sep 9, 2018 · 2 comments
Labels

Comments

@giuliohome
Copy link

giuliohome commented Sep 9, 2018

Hello!
First of all, congrats, this is a nice project, quite complex for me (I'm used to MVVM but not to Elmish approach).
I'm mentioning a sample of Gjallarhorn.Bindable after a long trail in a closed Elmish.WPF issue.
The only reason why I am disturbing you is that users would obviously prefer to have the possibility to open two items at the same time so that they could possibly compare them.
Anyway from a technical standpoint I am looking at the Nav.fs under the project Gjallarhorn.Bindable.Wpf and specifically at the code lines

        | ModalDialog window ->
            window.Owner <- mainWindow
            window.ShowDialog() |> ignore

I've done a very quick, dirty and rough change by replacing ShowDialog with Show and it looks like it would work as expected so maybe you might want to add an enhancement to open new modeless windows? I'd be very happy, but thanks anyway!

@ReedCopsey
Copy link
Owner

Yes, that works fine. The Collections sample shows multiple modeless windows already, BTW.

@ReedCopsey
Copy link
Owner

ReedCopsey commented Sep 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants