Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal "-Errors" and "-IsValid" properties use dashes that invalid as property path in Avalonia #29

Open
FoggyFinder opened this issue Jun 6, 2019 · 2 comments
Labels

Comments

@FoggyFinder
Copy link
Collaborator

Functions getErrorsPropertyName and getValidPropertyName provides PropertyName that invalid in Avalonia:

    let getErrorsPropertyName propertyName =
        propertyName + "-" + "Errors"
    let getValidPropertyName propertyName =
        propertyName + "-" + "IsValid"

#2621

So, attempt to use them on Avalonia as for WPF will fail.

Even if Avalonia allow use dashes someday (rather not, I think) it's a problem now.
I see only three options yet:

  1. To document it somewhere (something like list of features that unavailable in Avalonia or other platforms)
  2. To provide other implementation for these functions for Avalonia.
  3. To change implementation of these functions the way that names have been supported on all platforms.
@ReedCopsey
Copy link
Owner

Might be worth bringing up on Avalonia to see if they want to allow it first.

The problem with "fixing" this on our end is there is no possible way to fix it that wouldn't potentially cause conflicts with user-defined properties, as the fix would mean not using "unrepresentable names". This is a common thing done by compilers/etc, as it allows differentiation without conflict from user code. If Avalonia would support it (which is probably more of a matter of explicitly not checking for it, would be my guess), it'd be better for everybody in the long run.

@FoggyFinder
Copy link
Collaborator Author

I've created issue there at first - link just below code in description. Probably I had to do it more clearly.

This issue I created in trying to find at least temporary solution until Avalonia made the final decision.

ReedCopsey pushed a commit that referenced this issue Jun 11, 2019
* update readMe with information about #29

* Added mention of `UIType.Messages`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants