-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding .editorconfig breaks TreatWarningsAsErrors #56
Comments
Removing this line appears to fix the issue. Lines 71 to 74 in 7b1927e
Replacing with specific defaults is advised otherwise all warnings become errors.
Related issue |
Thanks @JimBobSquarePants! I was following that Roslyn thread and thought this was fixed since they closed the issue but perhaps not. Which version of VS are you using? |
No worries 😄 |
Raised new issue dotnet/roslyn#55541. |
Looks like there was a fix for this issue. Perhaps it can be closed now? |
Looks like the fix was rolled out in 17.2. Closing. Thanks for reporting. |
Describe the bug
Adding the
.editorconfig
file from repo main breaksTreatWarningsAsErrors
To Reproduce
Release
and build..editorconfig
file and rebuild. Build will fail.Expected behaviour
When the build configuration is set to release the build should fail.
Rules
Provide links to any rules in question.
The text was updated successfully, but these errors were encountered: