Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign login and register #1

Open
hlee opened this issue Jan 11, 2014 · 7 comments
Open

redesign login and register #1

hlee opened this issue Jan 11, 2014 · 7 comments

Comments

@hlee
Copy link
Member

hlee commented Jan 11, 2014

@caok took it

@ghost ghost assigned caok Jan 12, 2014
@caok
Copy link
Contributor

caok commented Jan 12, 2014

@hlee
The home page use big picture or something like map?

If use big picture, maybe we can do it like this

@caok
Copy link
Contributor

caok commented Jan 18, 2014

@hlee
I found that there are four kind of "devise_for" in the file of routes.rb. Maybe we need four different types of user, but the only one entrance for "login" and "registration" will be better.

Last night I thought about the whole structure, maybe we can refactor it like this:
1.we create a "User" model; "donors" and "requesters" succession of "User"
2.Set a field "type" to distinguish between different types of "user"

@hlee
Copy link
Member Author

hlee commented Jan 18, 2014

@caok I think slideshow is good enough. just need some images? We can find some sample image and put it there first

@hlee
Copy link
Member Author

hlee commented Jan 18, 2014

About the user structure, It's fine to redesign it. Just make it.

@hlee
Copy link
Member Author

hlee commented Jan 18, 2014

@EdmundMai , What do you think? Would you like to start with that part?

@EdmundMai
Copy link
Member

Sure I'll get started on it.

On Fri, Jan 17, 2014 at 10:41 PM, Ken [email protected] wrote:

@EdmundMai https://github.com/EdmundMai , What do you think? Would you
like to start with that part?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-32673584
.

@EdmundMai
Copy link
Member

I've committed my changes and made a pull request. Please review/accept and
let me know if you have any questions or want to discuss about my
implementation.

On Sat, Jan 18, 2014 at 12:28 AM, Edmund Mai [email protected] wrote:

Sure I'll get started on it.

On Fri, Jan 17, 2014 at 10:41 PM, Ken [email protected] wrote:

@EdmundMai https://github.com/EdmundMai , What do you think? Would you
like to start with that part?


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-32673584
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants