Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window functions #27

Open
piccolbo opened this issue Aug 11, 2015 · 3 comments
Open

window functions #27

piccolbo opened this issue Aug 11, 2015 · 3 comments
Labels
bug

Comments

@piccolbo
Copy link
Collaborator

none of the window functions work.
Excited by the announcement that SparkSQL now supports window functions I endeavored to make sure that they are supported in dplyr-spark. Since they are supported in dplyr. I created a new test file with the dplyr window-function examples in the linked to document above. None of the generated queries work in sparkSQL. I suspect these window function extensions are not completely standard. Need to investigate further.
piccolbo added a commit that referenced this issue Aug 11, 2015
@piccolbo
improves #27. lag/lead still not working.
85eda4e
@piccolbo
Copy link
Collaborator Author

some of these problems depend on tidyverse/dplyr#1060

piccolbo added a commit that referenced this issue Aug 12, 2015
@piccolbo
add custom win functions in the appropriate way #27
7e5c1fa
piccolbo added a commit that referenced this issue Aug 12, 2015
@piccolbo
monkey patch for over, #27
e3095b2
@piccolbo
Copy link
Collaborator Author

Passes the dplyr tutorial. We can close this as soon as dplyr#1060 closes.

@piccolbo piccolbo added the bug label Aug 12, 2015
@piccolbo piccolbo mentioned this issue Aug 13, 2015
Closed
@piccolbo
Copy link
Collaborator Author

By the way we monkey patched #1060 so this is open only to remove the monkey patch when it's time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piccolbo