Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: setDoSeq() attempts to remove the incorrect variables on error #25

Open
HenrikBengtsson opened this issue Dec 28, 2020 · 1 comment · May be fixed by #26
Open

BUG: setDoSeq() attempts to remove the incorrect variables on error #25

HenrikBengtsson opened this issue Dec 28, 2020 · 1 comment · May be fixed by #26

Comments

@HenrikBengtsson
Copy link

Analogously, to setDoPar(), the setDoSeq() function attempts to undo partially set variables in case there's an error;

foreach/R/setDoSeq.R

Lines 31 to 47 in 731cff6

setDoSeq <- function(fun, data=NULL, info=function(data, item) NULL) {
tryCatch(
{
assign('seqFun', fun, pos=.foreachGlobals, inherits=FALSE)
assign('seqData', data, pos=.foreachGlobals, inherits=FALSE)
assign('seqInfo', info, pos=.foreachGlobals, inherits=FALSE)
}, error = function(e) {
if (exists('fun', where=.foreachGlobals, inherits=FALSE))
remove('fun', envir = .foreachGlobals)
if (exists('data', where=.foreachGlobals, inherits=FALSE))
remove('data', envir = .foreachGlobals)
if (exists('info', where=.foreachGlobals, inherits=FALSE))
remove('info', envir = .foreachGlobals)
e
})
}

However, due to what looks like a cut'n'paste mistake from setDoPar(), setDoSeq() removes the wrong variables.
HenrikBengtsson added a commit to HenrikBengtsson/foreach that referenced this issue Dec 28, 2020
@HenrikBengtsson
BUG FIX: setDoSeq() removes the wrong variables if there's an error (f…
edeeddb 
…ixes RevolutionAnalytics#25)
@HenrikBengtsson HenrikBengtsson linked a pull request Dec 28, 2020 that will close this issue
Open
@HenrikBengtsson
Copy link
Author

HenrikBengtsson commented Dec 28, 2020 •
edited
Loading

PR #26 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG FIX: setDoSeq() removes the wrong variables if there's an error HenrikBengtsson/foreach
1 participant
@HenrikBengtsson