Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Movie review #22

Closed
ReznikovRoman opened this issue Jun 28, 2022 · 2 comments · Fixed by #30
Closed

[FEATURE] Movie review #22

ReznikovRoman opened this issue Jun 28, 2022 · 2 comments · Fixed by #30
Assignees
@ReznikovRoman
Labels
e/9 Estimate 9 hours feature New feature or request

Comments

@ReznikovRoman
Copy link
Owner

ReznikovRoman commented Jun 28, 2022 •
edited
Loading

Description
Добавить к фильмам пользовательские рецензии. Используем MongoDB.
В базовой версии рецензия содержит только текст и ссылку на фильм и пользователя.
В будущем, возможно, у рецензии появятся оценки пользователей (как это сделано на Кинопоиске).

Possible solution

  1. Добавить новый топик в Kafka для пользовательских рецензий
  2. Добавить консьюмера, который будет читать сообщения из топика и сохранять данные в БД
  3. Сделать необходимые сервисы и репозитории
  4. Сделать эндпоинты
    • POST /api/v1/users/me/reviews/films/{film_id} для получения пользовательской рецензии и создания сообщения в топике
    • GET /api/v1/reviews/films/{film_id} для получения всех рецензий в фильме. Для этого эндпоинта необходима пагинация. В этом же эндпоинте в будущем, возможно, нужно будет возвращать оценки самой рецензии
    • *POST /api/v1/users/me/reviews/{review_id}/ratings для добавления оценки к рецензии (была ли полезна или нет)
  5. Написать функциональные тесты на новые эндпоинты

Additional context
@ReznikovRoman ReznikovRoman added feature New feature or request e/9 Estimate 9 hours labels Jun 28, 2022
@ReznikovRoman ReznikovRoman self-assigned this Jun 28, 2022
@ReznikovRoman ReznikovRoman pinned this issue Jul 1, 2022
ReznikovRoman added a commit that referenced this issue Jul 3, 2022
@ReznikovRoman
#22: refactor: split function ugc.containers.override_providers int…
c45c8c2 
…o multiple ones
ReznikovRoman added a commit that referenced this issue Jul 3, 2022
@ReznikovRoman
#22: feat: configure MongoDB
6f59db9
ReznikovRoman added a commit that referenced this issue Jul 3, 2022
@ReznikovRoman
#22: refactor: rename base repository (BaseRepository -> `BaseRedis…
88e8454 
…Repository`)
ReznikovRoman added a commit that referenced this issue Jul 3, 2022
@ReznikovRoman
#22: feat: configure motor MongoDB client
b0675a8
@ReznikovRoman
Copy link
Owner Author

Рецензии на фильм не будем класть в очередь - сразу сохраняем в БД

ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: chore: add OpenAPI tag to the healthcheck endpoint
cea2f0e
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: refactor: inject Redis repository instead of inheriting from a b…
4b198e6 
…ase class
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: refactor: use orjson_response in exception handler
313f170
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: docs: update index.md with new endpoints
849e1d2
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: WIP: feat: add basic review repositories and services
c50ba11
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: WIP: feat: add API endpoint for creating new film reviews
fe5065d
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: add clients for MongoDB database and collection
d486fb6
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: update repositories and services to save reviews to the Mo…
073d80f 
…ngoDB
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: chore: use data from request body to create a new user review
44f99c2
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: add new field to the FilmReview - created_at
d111980
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: chore: add new method find to the Mongo client
53fb06b
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: add common MongoRepository for working with data from Mo…
28df02b 
…ngoDB
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: add methods to repository and service to get paginated rev…
0936374 
…iews
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: feat: add API endpoint /reviews/films/{film_id} for retrieving…
a400614 
… film reviews
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: test: fix flaky test `TestFilmProgressRetrieve.test_latest_progr…
b791667 
…ess`
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: chore: rename MongoDB section in settings
b102502
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: test: modify AuthClient to be able to create different users
75ce03b
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: test: configure MongoDB for tests
0c4256e
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: test: test /api/v1/users/me/reviews/films/{film_id} endpoint
7ac4126
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: test: test /api/v1/reviews/films/{film_id} endpoint
52a7529
@ReznikovRoman ReznikovRoman mentioned this issue Jul 10, 2022
Open
@ReznikovRoman
Copy link
Owner Author

Пользовательские оценки рецензий будут сделаны в рамках #29

@ReznikovRoman ReznikovRoman mentioned this issue Jul 10, 2022
Merged
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: chore: add MongoDB service to the GitHub Actions
9415914
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: fix: remove redundant option from MongoDB service
c64b6a6
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: fix: change MongoDB healthcheck
c2a28bd
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
#22: fix: change MongoDB healthcheck
a394bbc
ReznikovRoman added a commit that referenced this issue Jul 10, 2022
@ReznikovRoman
Merge pull request #30 from ReznikovRoman/feature/#22-movie_review
f43aba4 
feature/#22-movie review
@ReznikovRoman ReznikovRoman unpinned this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReznikovRoman ReznikovRoman

Labels
e/9 Estimate 9 hours feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature/#22-movie review ReznikovRoman/netflix-ugc
2 participants
@weAreStarsDust @ReznikovRoman