Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text marks not supported in legend #42

Open
jwildfire opened this issue Mar 27, 2017 · 3 comments · May be fixed by #272
Open

text marks not supported in legend #42

jwildfire opened this issue Mar 27, 2017 · 3 comments · May be fixed by #272
Assignees
Labels
Milestone

Comments

@jwildfire
Copy link
Contributor

jwildfire commented Mar 27, 2017

It might actually be more that the combination of text and non-text marks is breaking ...

@jwildfire jwildfire added this to the v1.8.0 milestone May 3, 2017
@emmorris
Copy link

emmorris commented May 3, 2017

This bug came up while we were working on codebook. We will need to investigate further to determine when it is breaking. This was discovered when we were using the vertical bar for the dot plots. The overall text mark next to the grouped bars was not renderering. For now, Jeremy hard coded the fix in the call back, but we don't want to continue doing that.

@jwildfire jwildfire added the bug label May 3, 2017
@jwildfire jwildfire modified the milestones: v1.7.1, v1.8.0 May 3, 2017
@jwildfire jwildfire modified the milestones: v1.8.0, v1.7.2 May 9, 2017
@jwildfire jwildfire modified the milestone: v1.9.0 Aug 26, 2017
@jwildfire jwildfire added this to the v1.11.7 milestone Nov 18, 2019
@samussiah
Copy link
Contributor

@jwildfire , I don't grok the issue here. For one, text marks aren't affected by color_by. Should they be? Or is the issue that the legend doesn't appear for charts with text marks in addition to other marks?

@samussiah samussiah reopened this Dec 16, 2019
@samussiah
Copy link
Contributor

Nevermind, 'text' isn't a supported legend mark. Defaulting to 'square'.

samussiah added a commit that referenced this issue Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants