Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visit_col, visitn_col and studyday_col` options #130

Open
jwildfire opened this issue Apr 25, 2019 · 1 comment
Open

add visit_col, visitn_col and studyday_col` options #130

jwildfire opened this issue Apr 25, 2019 · 1 comment

Comments

@jwildfire
Copy link
Contributor

Main goal is to sync the settings as much as possible with other renderers. The new settings would be used to populate time_cols as follows:

if(settings.visit_col & settings.visitn_col){
  ordinal_time_col =   {
    "type": "ordinal",
    "value_col": settings.visit_col,
    "label": "Visit",
    "order_col": settings.visitn_col,
    "order": null,
    "rotate_tick_labels": true,
    "vertical_space": 100
  }
}
settings.time_cols.push(ordinal_time_col)

if(settings.studyday_col){
  linear_time_col = {
    "type": "linear",
    "value_col": settings.studyday_col,
    "label": "Study Day",
    "order_col": settings.studyday_col,
    "order": null,
    "rotate_tick_labels": false,
    "vertical_space": 0
  }
  settings.time_cols.push(linear_time_col)
}
@jwildfire
Copy link
Contributor Author

@samussiah @pburnsdata You see any major issues with this approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant