Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wring C# code generation in version 14.0.0.0 RC (.net 8) #4620

Open
trudyhood opened this issue Nov 30, 2023 · 7 comments
Open

Wring C# code generation in version 14.0.0.0 RC (.net 8) #4620

trudyhood opened this issue Nov 30, 2023 · 7 comments

Comments

@trudyhood
Copy link

Hi,
NSwag command line tool for .NET Core Net80, toolchain v14.0.0.0 (NJsonSchema v11.0.0.0 (Newtonsoft.Json v13.0.0.0))

The API is this:
image

And the NSwag-generated code is this:
image

NSwag doesn't replace the client ID. It was working fine in the previous version.

@RicoSuter
Copy link
Owner

@paulomorgado seems to be a regression with PR
#4579
could you have a look?

@RicoSuter
Copy link
Owner

Is this still an issue with the latest preview?

@paulomorgado
Copy link
Contributor

This should have been solved by now.

I'll add a test for that to confirm.

@trudyhood
Copy link
Author

Thank you,
Where is the MSI package for the latest pre-release?

@paulomorgado
Copy link
Contributor

Just created PR #4634 with tests added for this pattern.

Code generated now should be something like:

urlBuiIder_.Append("projects /" ) ;
urtBuitder_.Append(System.Uri.EscapeDataString(ConvertToString(projectld, System.Globalization.CultureInfo.InvariantCulture)));
urtBuitder_.Append("/devices/clientld:");
urtBuitder_.Append(System.Uri.EscapeDataString(ConvertToString(clientld, System.Globalization.CultureInfo.InvariantCulture)));

Can you check, @trudyhood?

@trudyhood
Copy link
Author

trudyhood commented Dec 11, 2023

Can you check, @trudyhood?
@paulomorgado Sorry, I am not sure where can I find the latest binary. Do I need to compile the latest nswag preview myself?

@paulomorgado
Copy link
Contributor

Can you check, @trudyhood?

@paulomorgado Sorry, I am not sure where can I find the latest binary. Do I need to compile the latest nswag preview myself?

That would be a sure way of getting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants