-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CODE] Upgrade react to v18.2 #201
Comments
Issues:
|
At this point is sank hours/days into trying to get the gapText component to work without ReactDom.render but every solution just comes with a range of new problems (rerenders, unfocused, breaking dom elements). GapText and GapTextDropdown both use ReactMarkdown to first create the html for the question and then insert inputs or dropdowns into the defined positions with ReactDom.render(). Unfortunately React 18 removes support for this. The previous option allowed to usage of markdown Option 1: <ReactMarkdown
{/*...*/}
components={{
p: ({ node, ...props }) => (
<p>
{/*Function to insert input element*/}
</p>
),
}} Option 2: Option 3: Option 4: |
…ilding_construction:Replaced ReactDom.render (#201)
* Upgraded to react 18 * Fixed progress not animating * Fixed React-Modal: Cannot register modal instance that's already open * Updated cypress to react 18 * Upgraded framer-motion + removed d3-ease * Fixed first question being fetched twice * refactored gap-text and gap-text dropdown
No description provided.
The text was updated successfully, but these errors were encountered: