Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"This is not yet production ready" #67

Open
jonathanstrong opened this issue Oct 2, 2020 · 2 comments
Open

"This is not yet production ready" #67

jonathanstrong opened this issue Oct 2, 2020 · 2 comments

Comments

@jonathanstrong
Copy link

hello,

Thank you for publishing this library and all the hard work you've put into it!

I was wondering if you could possibly offer additional explanation regarding the statement in the documentation, "This is not yet production ready." Specifically, what aspects of the library do you consider not to be production ready?

thank you!

Jonathan

@lemire
Copy link
Member

lemire commented Oct 2, 2020

For context, this remark in the README was written 6 years ago.

@Nemo157
Copy link
Collaborator

Nemo157 commented Oct 5, 2020

Yeah, this was the first Rust code I ever wrote (started just before Rust 1.0 came out 😁) so I wanted to temper any expectations on it. I think in terms of functionality it is fine to use, what is there should work (well, hopefully, #62). The biggest things I have not got around to doing since I have become more familiar with Rust are:

  1. A complete API review. When this was started the API norms weren't as strong as they are now, so there are likely to be small inconsistencies in the API such as len should take constant-time #45, and new APIs are available to implement such as Implement Bounded Iterator #5.
  2. Benchmarking and optimization. A long time ago I started a benchmark suite comparing against croaring: https://github.com/Nemo157/roaring-bench-rs but I never got around to actually using it to optimize anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants