Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The merge of cli , default and file config should be simplify. #466

Open
TwistedSim opened this issue Jun 14, 2018 · 0 comments
Open

The merge of cli , default and file config should be simplify. #466

TwistedSim opened this issue Jun 14, 2018 · 0 comments
Labels

Comments

@TwistedSim
Copy link
Member

I have encontered some problems where the config is not initiated correctly when used in as class attribute.

At the moment, the merging of the config from those 3 place is a bit confusing, a ChainMap should solve this as it can be easily update with new config option. The order of importance should be: default < file config < cli arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants