-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self-contained examples #309
Comments
This was referenced Sep 23, 2024
Merged
This was referenced Oct 3, 2024
This is getting close to finished! Once you think everything is done, please ping me. |
@jwnimmer-tri Here is your reminder since the github ci PR is now merged. I haven't created a PR for the workflow copies yet so I thought here would be apt. |
See #331 for an outline of one next steep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fundamental idea of this repository is that users should always be able to copy just one subdirectory and end up with everything they need. To the extent that we have important files outside of the
drake_...
subdirectories, the examples will be broken.#307 jump starts the process of fixing one violation of the fundamental idea. The call to action in this issue is to fix 100% of the violations. That means thins like moving more files (CPPLINT, LICENSE). The
.gitattributes
should not move -- it's a tool for Reviewable, so must live at the root.The second major prong here will be splitting the
.github
GHA rules as well. For example, we wantdrake_cmake_installed/.github/workflows/ci.yml
to be a CI recipe that would work correctly in case a user copied it to their own project (under the usual premise that they name their repomy_project
top level instead ofdrake-external-examples/drake_cmake_installed
nested -- the "copy one subdir" part). We still need to have our top-leveldrake-external-examples/.github/workflows/ci.yml
to trigger our builds in our own repository, but it needs to be refactored to cite the other subdir yml files by reference, so that it's relatively thin. In the past I've found the GHA syntax for citing other files, but I don't have it handy right now. Or as another approach, possibly there is a way to have yml file in the subdir be copied (with another name?) into our main github workflows, and use thefile_sync_test
to keep them aligned.The text was updated successfully, but these errors were encountered: