Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drake_ament_cmake_installed] Broken link in README #310

Closed
BetsyMcPhail opened this issue Sep 19, 2024 · 3 comments
Closed

[drake_ament_cmake_installed] Broken link in README #310

BetsyMcPhail opened this issue Sep 19, 2024 · 3 comments

Comments

@BetsyMcPhail
Copy link
Contributor

In the drake_ament_cmake_installed README, the ament_cmake link is broken.

@jwnimmer-tri jwnimmer-tri changed the title Broken link in ament cmake installed README [drake_ament_cmake_installed] Broken link in README Oct 29, 2024
@ahcorde
Copy link

ahcorde commented Oct 30, 2024

The right link is https://docs.ros.org/en/rolling/How-To-Guides/Ament-CMake-Documentation.html

you might want to change the ROS distro branch

@jwnimmer-tri
Copy link
Contributor

Great, thanks!

Since the example is hard-coded to Humble, let's use this link:

When we upgrade from Humble to something newer, we can change the docs and setup scripts at the same time.

+@BetsyMcPhail could you or @nicolecheetham please open a PR for this?

@jwnimmer-tri
Copy link
Contributor

Fixed in #337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants