Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Read parameters from a robot description (URDF) #1

Open
evan-palmer opened this issue Oct 27, 2023 · 3 comments
Open

[FEATURE]: Read parameters from a robot description (URDF) #1

evan-palmer opened this issue Oct 27, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@evan-palmer
Copy link
Contributor

Feature Type

Adding new functionality

Problem Description

User's currently need to manually provide hydrodynamic parameters which is ok if you are using a configuration file. But this process is tedious and is a bit of an eye-sore.

Feature Description

Implement a parser capable of parsing hydrodynamic parameters from a robot's URDF file. This would fit in with the more traditional robotics modeling approach (using URDF instead of a configuration file) and would be much easier to use.

Alternative Solutions

You could instead write just a generic parser, which would be fine, but ultimately I think that supporting URDF configurations specifically should be a higher priority.

Additional Context

SDFormat provides something similar for Gazebo. It might be useful to provide support for that format of parameters to avoid forcing users to duplicate things.

@evan-palmer evan-palmer added the enhancement New feature or request label Oct 27, 2023
@evan-palmer
Copy link
Contributor Author

I recently found out that SDF files have started to get better support in ROS 2, and with the existing integration of hydrodynamics into Gazebo, I think it would be better to implement an SDF parser instead of a URDF parser.

@arjo129
Copy link

arjo129 commented Apr 12, 2024

Hey @evan-palmer just came across this repo! Nice to see peolpe playing around with hydrodynamics. Was wondering if you've had a look at http://sdformat.org/spec?ver=1.11&elem=link#inertial_fluid_added_mass . You don't need to implement a parser from scratch but can just depend on libSDFormat.

@evan-palmer
Copy link
Contributor Author

Hey @arjo129! Thank you for sharing this. I'm glad to see that there is already some support for parsing hydrodynamics! When I wrote this issue, I was thinking of the implementation that you and Carlos put together for the VRX hydrodynamics plugin here

@evan-palmer evan-palmer self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants