Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo::detach() can change servo position #19

Open
dkwach opened this issue Oct 31, 2022 · 0 comments
Open

Servo::detach() can change servo position #19

dkwach opened this issue Oct 31, 2022 · 0 comments
Labels

Comments

@dkwach
Copy link

dkwach commented Oct 31, 2022

it is useful to detach servo after movement in cases like:

  • limit current consumption (servo mechanic could keep position without electronic control for small forces)
  • limit servo vibrations (usually present in cheap servos) - sometimes we can observe vibrations after reaching designed position

In current implementation (if I understood correctly) detach() is not controlling pwm state and can disable pwm during high state and move servo to different position.

It would be great to support some safe detach, which will check if pwm is not in active state and won't change servo position.
Proposal for interface:

detach(bool isSafe=false); //false default to keep backward compatibility 
or
safeDetach();
@JarekParal JarekParal added the bug label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants