Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of the selecting and releasing the channels in attach() and detach() #2

Open
JarekParal opened this issue Apr 16, 2018 · 0 comments
Open

Fix implementation of the selecting and releasing the channels in attach() and detach() #2

JarekParal opened this issue Apr 16, 2018 · 0 comments
Labels
enhancement

Comments

@JarekParal
Copy link
Member

JarekParal commented Apr 16, 2018 •
edited
Loading

Not very good implementation of the selecting and releasing the channels for the ledcSetup() function:
https://github.com/RoboticsBrno/ESP32-Arduino-Servo-Library/blob/master/src/Servo.cpp#L49

Tip: implement by std:bitset to remember used channels.
@JarekParal JarekParal mentioned this issue Mar 1, 2019
Open
@JarekParal JarekParal changed the title Fix bug in attach() and detach() channels Fix implementation of the selecting and releasing the channels in attach() and detach() Mar 1, 2019
@JarekParal JarekParal mentioned this issue Sep 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JarekParal